This repository was archived by the owner on Jan 24, 2023. It is now read-only.
Fixing cloning issue #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning an event sourced message, the parent child relationships of the clone were broken.
wackoisgod
suggested changes
Aug 30, 2018
Contributor
wackoisgod
left a comment
wackoisgod
left a comment
There was a problem hiding this comment.
is there any overall perf implications of this change ?
| printer->Print(vars, | ||
| "$name$_ = new EventMapField<$key_type_name$, $value_type_name$>($name$MapConverter, Context, $number$, true);\n"); | ||
| } | ||
| else { |
Contributor
There was a problem hiding this comment.
Are we creating a dependencies now on the EventSource code even when the message is not sourced ?
| public MessageB() { | ||
| OnConstruction(); | ||
| c_.SetContext(Context, 2); | ||
| c_ = new EventMapField<string, global::Com.Zynga.Runtime.Protobuf.File.MessageC>(cMapConverter, Context, 2, true); |
Contributor
There was a problem hiding this comment.
Please fix the tabbing int he generator 👎
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning an event sourced message, the parent child relationships of the clone were broken.